[PATCH] D130645: Move mlir LogicalResult to llvm Support library

[River Riddle via Phabricator via llvm-commits]

rriddle added a comment.

I mean this looks fine to me, but would love review from those Mehdi linked.



================
Comment at: llvm/include/llvm/Support/LogicalResult.h:76
 /// also providing a value on the success path.
-template <typename T>
-class LLVM_NODISCARD FailureOr : public Optional<T> {
+template <typename T> class LLVM_NODISCARD FailureOr : public Optional<T> {
 public:
----------------
The formatting here looks off.


================
Comment at: llvm/include/llvm/Support/LogicalResult.h:102
 
-/// This class represents success/failure for parsing-like operations that find
-/// it important to chain together failable operations with `||`.  This is an
----------------
I know some downstream users would benefit from this, not sure how that would manifest (rename or something) if we find it desirable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130645/new/

https://reviews.llvm.org/D130645