[PATCH] D130494: [InstCombine] Adjust snprintf folding of constant strings (PR #56598)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 10:59:00 PDT 2022


efriedma added a comment.

There are two separate conditions noted in POSIX related to EOVERFLOW (https://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html):

- The value to be returned is greater than {INT_MAX}
- The value of n is greater than {INT_MAX}

To be clear, this is intended to address the case of the value of "n", but not the case of the value to be returned?  (I guess it would be a bit of a pain to write a testcase.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130494/new/

https://reviews.llvm.org/D130494



More information about the llvm-commits mailing list