[PATCH] D130592: [IR] Move support for dxil::TypedPointerType to LLVM core IR.

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 09:11:33 PDT 2022


beanz added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILWriter/DXILValueEnumerator.cpp:376
     EnumerateType(
         dxil::TypedPointerType::get(F.getFunctionType(), F.getAddressSpace()));
     EnumerateAttributes(F.getAttributes());
----------------
This needs to drop the dxil namespace.


================
Comment at: llvm/lib/Target/DirectX/DXILWriter/DXILValueEnumerator.cpp:397
     EnumerateType(
         dxil::TypedPointerType::get(GV.getValueType(), GV.getAddressSpace()));
     if (GV.hasAttributes())
----------------
Here too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130592/new/

https://reviews.llvm.org/D130592



More information about the llvm-commits mailing list