[PATCH] D130174: [Matrix] Refactor transpose distribution. NFC
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 27 08:29:47 PDT 2022
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:388
+
+ // Transpose the shape.
+ ShapeInfo t() const { return ShapeInfo(NumColumns, NumRows); }
----------------
nit: Should be `///` for doc-comment?
Might be good to say this returns the transposed shape?
================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:690
+ // (Op0 op Op1)^T -> Op0^T op Op1^T
+ // Transpose \p Op0 and \p Op1 of shape \p Shape0 and \p Shape1, then use them
----------------
nit: `///` for doc-comment
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130174/new/
https://reviews.llvm.org/D130174
More information about the llvm-commits
mailing list