[PATCH] D130543: [RISCV]Enable isIntDivCheap when attribute is minsize
Liao Chunyu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 27 03:26:25 PDT 2022
liaolucy added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:12530
+ // instruction, as it is usually smaller than the alternative sequence.
+ // TODO: Add vector division?
+ bool OptSize = Attr.hasFnAttr(Attribute::MinSize);
----------------
pcwang-thead wrote:
> The reason why other targets make vector an exception is because there is no vector integer division as the comments said, so I think it is OK for RVV since there are vector integer divide instructions. While for P extension, it could be an exception.
Yes, that is why I added a TODO.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130543/new/
https://reviews.llvm.org/D130543
More information about the llvm-commits
mailing list