[llvm] 8d46cb3 - Emit a simple StackSizesSection on PS4.

[Ying Yi via llvm-commits]

Author: Ying Yi
Date: 2022-07-27T09:39:24+01:00
New Revision: 8d46cb343f52a33e89db652176fa104ce8d875fe

URL: https://github.com/llvm/llvm-project/commit/8d46cb343f52a33e89db652176fa104ce8d875fe
DIFF: https://github.com/llvm/llvm-project/commit/8d46cb343f52a33e89db652176fa104ce8d875fe.diff

LOG: Emit a simple StackSizesSection on PS4.

Differential Revision: https://reviews.llvm.org/D130495

Added: 
    

Modified: 
    llvm/lib/MC/MCObjectFileInfo.cpp
    llvm/test/CodeGen/X86/stack-size-section.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/MC/MCObjectFileInfo.cpp b/llvm/lib/MC/MCObjectFileInfo.cpp
index d6fe952c0c1d8..a7655c9e49e56 100644
--- a/llvm/lib/MC/MCObjectFileInfo.cpp
+++ b/llvm/lib/MC/MCObjectFileInfo.cpp
@@ -1103,7 +1103,8 @@ MCSection *MCObjectFileInfo::getDwarfComdatSection(const char *Name,
 
 MCSection *
 MCObjectFileInfo::getStackSizesSection(const MCSection &TextSec) const {
-  if (Ctx->getObjectFileType() != MCContext::IsELF)
+  if ((Ctx->getObjectFileType() != MCContext::IsELF) ||
+      Ctx->getTargetTriple().isPS4())
     return StackSizesSection;
 
   const MCSectionELF &ElfSec = static_cast<const MCSectionELF &>(TextSec);

diff  --git a/llvm/test/CodeGen/X86/stack-size-section.ll b/llvm/test/CodeGen/X86/stack-size-section.ll
index 74a0cba632c78..3652ee845a7f3 100644
--- a/llvm/test/CodeGen/X86/stack-size-section.ll
+++ b/llvm/test/CodeGen/X86/stack-size-section.ll
@@ -1,8 +1,12 @@
-; RUN: llc < %s -mtriple=x86_64-linux -stack-size-section | FileCheck %s
+; RUN: llc < %s -mtriple=x86_64-linux -stack-size-section | FileCheck %s --check-prefix=CHECK --check-prefix=GROUPS
+
+; PS4 'as' does not recognize the section attribute "o".  So we have a simple .stack_sizes section on PS4.
+; RUN: llc < %s -mtriple=x86_64-scei-ps4 -stack-size-section | FileCheck %s --check-prefix=CHECK --check-prefix=NOGROUPS
 
 ; CHECK-LABEL: func1:
 ; CHECK-NEXT: .Lfunc_begin0:
-; CHECK: .section .stack_sizes,"o", at progbits,.text{{$}}
+; GROUPS: .section .stack_sizes,"o", at progbits,.text{{$}}
+; NOGROUPS: .section .stack_sizes,"", at progbits
 ; CHECK-NEXT: .quad .Lfunc_begin0
 ; CHECK-NEXT: .byte 8
 define void @func1(i32, i32) #0 {
@@ -13,7 +17,8 @@ define void @func1(i32, i32) #0 {
 
 ; CHECK-LABEL: func2:
 ; CHECK-NEXT: .Lfunc_begin1:
-; CHECK: .section .stack_sizes,"o", at progbits,.text{{$}}
+; GROUPS: .section .stack_sizes,"o", at progbits,.text{{$}}
+; NOGROUPS: .section .stack_sizes,"", at progbits
 ; CHECK-NEXT: .quad .Lfunc_begin1
 ; CHECK-NEXT: .byte 24
 define void @func2() #0 {
@@ -24,14 +29,16 @@ define void @func2() #0 {
 
 ; Check that we still put .stack_sizes into the corresponding COMDAT group if any.
 ; CHECK: .section .text._Z4fooTIiET_v,"axG", at progbits,_Z4fooTIiET_v,comdat
-; CHECK: .section .stack_sizes,"Go", at progbits,_Z4fooTIiET_v,comdat,.text._Z4fooTIiET_v{{$}}
+; GROUPS: .section .stack_sizes,"Go", at progbits,_Z4fooTIiET_v,comdat,.text._Z4fooTIiET_v{{$}}
+; NOGROUPS: .section .stack_sizes,"", at progbits
 $_Z4fooTIiET_v = comdat any
 define linkonce_odr dso_local i32 @_Z4fooTIiET_v() comdat {
   ret i32 0
 }
 
 ; CHECK: .section .text.func3,"ax", at progbits
-; CHECK: .section .stack_sizes,"o", at progbits,.text.func3{{$}}
+; GROUPS: .section .stack_sizes,"o", at progbits,.text.func3{{$}}
+; NOGROUPS: .section .stack_sizes,"", at progbits
 define dso_local i32 @func3() section ".text.func3" {
   %1 = alloca i32, align 4
   store i32 0, ptr %1, align 4