[PATCH] D130579: AMDGPU: Remove manual selection for atomic fadd

[Abinav Puthan Purayil via Phabricator via llvm-commits]

abinavpp added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/BUFInstructions.td:1593
   }];
+  let HasNoUse = true;
 }
----------------
Can we remove the PredicateCode and GISelPredicateCode above?


================
Comment at: llvm/lib/Target/AMDGPU/FLATInstructions.td:1031
+                                         ValueType data_vt = vt,
+                                         int complexity = 0, bit isIntr = 0> {
   defvar noRtnNode = !cast<PatFrags>(node # "_noret" # !if(isIntr, "", "_" # vt.Size));
----------------
Since you're splitting the ret and noret patterns to their own multiclasses, I think you can remove the complexity argument here and from FlatSignedAtomicPatImplRtn and use `let AddedComplexity = ... in` in the defms.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130579/new/

https://reviews.llvm.org/D130579