[PATCH] D130503: [ASan] Use stack safety analysis to optimize allocas instrumentation.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: llvm/test/Instrumentation/AddressSanitizer/asan-stack-safety.ll:19
 
 define i32 @load() sanitize_address {
   %buf = alloca [10 x i8], align 1
----------------
vitalybuka wrote:
> I believe all of existing tests are affected by the patch, but the signal is 
> missing @__asan_stack_malloc
> 
> Then with this patch we don't have a case:
> alloca is not save, but one of accesses is removed 
> I believe all of existing tests are affected by the patch, but the signal is 
> missing @__asan_stack_malloc
> 
> Then with this patch we don't have a case:
> alloca is not save, but one of accesses is removed 

To clarify, we need new test which contains in one function:
1 unsafe alloca
1 safe load or store (maybe constant offset)
1 unsafe load or store (maybe int function parameter offset)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130503/new/

https://reviews.llvm.org/D130503