[PATCH] D130503: [ASan] Use stack safety analysis to optimize allocas instrumentation.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: llvm/test/Instrumentation/AddressSanitizer/asan-stack-safety.ll:37
+  call void @llvm.lifetime.start.p0i8(i64 10, i8* nonnull %ptr)
+  store volatile i8 0, i8* %ptr, align 4, !tbaa !8
+  call void @llvm.lifetime.end.p0i8(i64 10, i8* nonnull %ptr)
----------------
Isn't this pass without the patch?


================
Comment at: llvm/test/Instrumentation/AddressSanitizer/asan-stack-safety.ll:61-63
+!8 = !{!9, !9, i64 0}
+!9 = !{!"omnipotent char", !10, i64 0}
+!10 = !{!"Simple C/C++ TBAA"}
----------------
probably we don't need these


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130503/new/

https://reviews.llvm.org/D130503