[PATCH] D128860: [llvm][NFC] Refactor code to use ProfDataUtils
Paul Kirth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 26 16:04:43 PDT 2022
paulkirth added a comment.
I've left the `extractProfMetadata` interface to `Instruction`, since I'm unsure if we want to force downstream users to update their code. We could alternatively just leave the interface as is, and back out the places where we've update usage.
I'm waffling on that one, and whether those updates should be a separate change, or just done here. There's value in leaving the public interface to Instruction alone. We've already moved the logic into a central place, so I'm less convinced that the rest of the refactor is the best approach.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128860/new/
https://reviews.llvm.org/D128860
More information about the llvm-commits
mailing list