[PATCH] D128560: An upcoming patch to LLDB will require the ability to decode base64. This patch adds support for decoding base64 and adds tests.

Tue Jul 26 15:55:45 PDT 2022

clayborg added a comment.

In D128560#3680975 <https://reviews.llvm.org/D128560#3680975>, @aprantl wrote:

> For compilation speed I would prefer sinking decodeBase64Byte() into a .cpp file and I would probably also prefer to move the implementation of decodeBase64() even if that means it can no longer be a template and we would need to require i.e., a SmallVectorImpl or something like that. Are there any really big advantages of making this a template?

I agree as I was wondering if decodeBase64Byte would cause problems being a static in the header file. I can make a cpp file and remove the template aspect.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128560/new/

https://reviews.llvm.org/D128560