[llvm] fd84d97 - Revert "[Support] Workaround compiler bug in MSVC"

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 15:50:29 PDT 2022


Author: Tom Stellard
Date: 2022-07-26T15:49:35-07:00
New Revision: fd84d97ba670746e013fd815ecaea7952d562428

URL: https://github.com/llvm/llvm-project/commit/fd84d97ba670746e013fd815ecaea7952d562428
DIFF: https://github.com/llvm/llvm-project/commit/fd84d97ba670746e013fd815ecaea7952d562428.diff

LOG: Revert "[Support] Workaround compiler bug in MSVC"

This reverts commit ec8f4fd68cd401a0ba41bb160d6acce670486fab.

This caused a failure in the mlir-windows bot.

Added: 
    

Modified: 
    llvm/lib/Support/NativeFormatting.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Support/NativeFormatting.cpp b/llvm/lib/Support/NativeFormatting.cpp
index e9854d093d4f2..8a69f75132555 100644
--- a/llvm/lib/Support/NativeFormatting.cpp
+++ b/llvm/lib/Support/NativeFormatting.cpp
@@ -262,11 +262,5 @@ size_t llvm::getDefaultPrecision(FloatStyle Style) {
   case FloatStyle::Percent:
     return 2; // Number of decimal places.
   }
-  // Workaround for MSVC bug in VS2022:
-  // https://developercommunity.visualstudio.com/t/Prev-Issue---with-__assume-isnan-/1597317
-  // llvm_unreachable expands to __assume(false) with MSVC which triggers the
-  // bug.
-#ifndef _MSC_VER
   llvm_unreachable("Unknown FloatStyle enum");
-#endif
 }


        


More information about the llvm-commits mailing list