[PATCH] D130189: [LoopInterchange][PR56275] Fix legality in dependence vectors

[Congzhe Cao via Phabricator via llvm-commits]

congzhe added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopInterchange.cpp:131
+        if (D->isDirectionNegative())
+          D->normalize(SE);
         LLVM_DEBUG(StringRef DepType =
----------------
Meinersbur wrote:
> Before I can accept the patch, I would like to see D130188 to treat a `Dependence` object as immutable (modifying global state is incompatible with pass manager analysis caching)
Thanks for the comment, I've updated D130188 such that `Dependence::normalize()` does not change `this` object but just returns a new `Depenence` object.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130189/new/

https://reviews.llvm.org/D130189