[PATCH] D129974: [BOLT] Support split jump table for stripped binaries

[Amir Ayupov via Phabricator via llvm-commits]

Amir added a comment.

@maksfb: does the updated summary look good? 
@nhuhuan: please address one typo. LGTM otherwise.



================
Comment at: bolt/lib/Core/BinaryContext.cpp:631
+    if (!isValidJumpTableEntry(Value, BF, ValidExternalTargetBF)) {
       LLVM_DEBUG({
         if (Value == BF.getAddress())
----------------
As a note for future improvement: instead of partially reconstructing the logic of isValidJumpTableEntry, we may enumerate the checks in isValidJTE and return the check number along with its result. 


================
Comment at: bolt/lib/Core/BinaryContext.cpp:638
+        else {
+          dbgs() << "FAIL: jump table are invalid:\n";
+          dbgs() << "  ! current function: " << BF.getPrintName() << "\n";
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129974/new/

https://reviews.llvm.org/D129974