[PATCH] D130500: Change long to int64_t (which is always 64 bit or 8 bytes )

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 10:28:09 PDT 2022


efriedma accepted this revision.
efriedma added a comment.

LGTM with formatting fixed.



================
Comment at: llvm/lib/Target/PowerPC/PPCFastISel.cpp:844
       const APInt &CIVal = ConstInt->getValue();
-      Imm = (IsZExt) ? (long)CIVal.getZExtValue() : (long)CIVal.getSExtValue();
+      Imm = (IsZExt) ? (int64_t)CIVal.getZExtValue() : (int64_t)CIVal.getSExtValue();
       if ((IsZExt && isUInt<16>(Imm)) || (!IsZExt && isInt<16>(Imm)))
----------------
clang-format is complaining this line is too long.

Might as well remove unnecessary parentheses around IsZExt while you're here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130500/new/

https://reviews.llvm.org/D130500



More information about the llvm-commits mailing list