[PATCH] D130141: [RISCV] Add MC support of RISCV Zca Extension

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 09:55:04 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoC.td:495
 
 def C_LWSP : CStackLoad<0b010, "c.lwsp", GPRNoX0, uimm8_lsb00>,
              Sched<[WriteLDW, ReadMemBase]> {
----------------
craig.topper wrote:
> Doesn't `C_LWSP` need to be updated? It's sharing with `C_FLDSP`
Ignore this I misread it.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoC.td:555
 
 def C_SWSP : CStackStore<0b110, "c.swsp", GPR, uimm8_lsb00>,
              Sched<[WriteSTW, ReadStoreData, ReadMemBase]> {
----------------
craig.topper wrote:
> `C_SWSP` needs to be updated
Ignore this I misread it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130141/new/

https://reviews.llvm.org/D130141



More information about the llvm-commits mailing list