[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

Tue Jul 26 09:18:58 PDT 2022

fhahn added a comment.

In D128955#3679418 <https://reviews.llvm.org/D128955#3679418>, @tejohnson wrote:

> lgtm
>
> In D128955#3676478 <https://reviews.llvm.org/D128955#3676478>, @aeubanks wrote:
>
>> In D128955#3676198 <https://reviews.llvm.org/D128955#3676198>, @tejohnson wrote:
>>
>>> In D128955#3674787 <https://reviews.llvm.org/D128955#3674787>, @aeubanks wrote:
>>>
>>>> random question, if the old API is "legacy", are there any plans to remove it?
>>>
>>> @fhahn started to work on this at some point (see https://bugs.llvm.org/show_bug.cgi?id=41541), but I'm not sure of the status. It is used by ld64 and I believe the sony toolchain too.
>>
>> if I'm seeing correctly, looks like there aren't any in-tree users of ThinLTOCodeGenerator/LTOCodeGenerator. are those out of tree?
>
> Yes, all linker users are out of tree. Only llvm-lto is in tree for testing.

AFAIK ld64 uses ThinLTOCodeGenerator/LTOCodeGenerator through libTLO, which is in-tree (`llvm/tools/lto/lto.cpp`)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128955/new/

https://reviews.llvm.org/D128955