[PATCH] D129133: ManagedStatic: remove some remaining dead references

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle updated this revision to Diff 447710.
nhaehnle added a comment.

Rebase


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129133/new/

https://reviews.llvm.org/D129133

Files:
  llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
  llvm/lib/Analysis/TensorSpec.cpp
  llvm/lib/LTO/LTO.cpp
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/ErrorHandling.cpp


Index: llvm/lib/Support/ErrorHandling.cpp
===================================================================
--- llvm/lib/Support/ErrorHandling.cpp
+++ llvm/lib/Support/ErrorHandling.cpp
@@ -47,8 +47,6 @@
 
 #if LLVM_ENABLE_THREADS == 1
 // Mutexes to synchronize installing error handlers and calling error handlers.
-// Do not use ManagedStatic, or that may allocate memory while attempting to
-// report an OOM.
 //
 // This usage of std::mutex has to be conditionalized behind ifdefs because
 // of this script:
Index: llvm/lib/Support/CMakeLists.txt
===================================================================
--- llvm/lib/Support/CMakeLists.txt
+++ llvm/lib/Support/CMakeLists.txt
@@ -3,7 +3,6 @@
 # Ensure that libSupport does not carry any static global initializer.
 # libSupport can be embedded in use cases where we don't want to load all
 # cl::opt unless we want to parse the command line.
-# ManagedStatic can be used to enable lazy-initialization of globals.
 # We don't use `add_flag_if_supported` as instead of compiling an empty file we
 # check if the current platform is able to compile global std::mutex with this
 # flag (Linux can, Darwin can't for example).
Index: llvm/lib/LTO/LTO.cpp
===================================================================
--- llvm/lib/LTO/LTO.cpp
+++ llvm/lib/LTO/LTO.cpp
@@ -38,7 +38,6 @@
 #include "llvm/Support/CommandLine.h"
 #include "llvm/Support/Error.h"
 #include "llvm/Support/FileSystem.h"
-#include "llvm/Support/ManagedStatic.h"
 #include "llvm/Support/MemoryBuffer.h"
 #include "llvm/Support/Path.h"
 #include "llvm/Support/SHA1.h"
Index: llvm/lib/Analysis/TensorSpec.cpp
===================================================================
--- llvm/lib/Analysis/TensorSpec.cpp
+++ llvm/lib/Analysis/TensorSpec.cpp
@@ -17,7 +17,6 @@
 #include "llvm/Support/CommandLine.h"
 #include "llvm/Support/Debug.h"
 #include "llvm/Support/JSON.h"
-#include "llvm/Support/ManagedStatic.h"
 #include "llvm/Support/MemoryBuffer.h"
 #include "llvm/Support/Path.h"
 #include "llvm/Support/raw_ostream.h"
Index: llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
===================================================================
--- llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
+++ llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
@@ -22,7 +22,6 @@
 #include "llvm/Analysis/Utils/TFUtils.h"
 #include "llvm/IR/LLVMContext.h"
 #include "llvm/Support/CommandLine.h"
-#include "llvm/Support/ManagedStatic.h"
 
 #include <vector>
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129133.447710.patch
Type: text/x-patch
Size: 2499 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220726/7f30ea9f/attachment.bin>