[PATCH] D130572: [CMake] Enable -z defs on Solaris

[Rainer Orth via Phabricator via llvm-commits]

ro created this revision.
ro added a reviewer: MaskRay.
Herald added subscribers: StephenFan, fedor.sergeev, mgorny, jyknight.
Herald added a project: All.
ro requested review of this revision.
Herald added a project: LLVM.

I wondered why I hadn't seen the link failures in D130571 <https://reviews.llvm.org/D130571> on Solaris/sparcv9 and found that Solaris, unlike Linux, doesn't use `-Wl,-z,defs` when linking shared objects.  The three affected shared objects indeed have undefined references to several 64-bit atomics.

This patch will expose such issues in the future by defaulting to `-Wl,-z,defs` on Solaris, as recommended in `ld(1)`.

Tested on `sparcv9-sun-solaris2.11` and `amd64-pc-solaris2.11`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D130572

Files:
  llvm/cmake/modules/HandleLLVMOptions.cmake


Index: llvm/cmake/modules/HandleLLVMOptions.cmake
===================================================================
--- llvm/cmake/modules/HandleLLVMOptions.cmake
+++ llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -228,7 +228,7 @@
 
 # Pass -Wl,-z,defs. This makes sure all symbols are defined. Otherwise a DSO
 # build might work on ELF but fail on MachO/COFF.
-if(NOT (CMAKE_SYSTEM_NAME MATCHES "Darwin|FreeBSD|OpenBSD|DragonFly|AIX|SunOS|OS390" OR
+if(NOT (CMAKE_SYSTEM_NAME MATCHES "Darwin|FreeBSD|OpenBSD|DragonFly|AIX|OS390" OR
         WIN32 OR CYGWIN) AND
    NOT LLVM_USE_SANITIZER)
   set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130572.447676.patch
Type: text/x-patch
Size: 670 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220726/2984b9a2/attachment.bin>