[PATCH] D130557: [Support] Add KnownBits::concatBits helper

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Seems reasonable. The API is a bit different from APInt::concat, but I never particularly liked that API anyway :)



================
Comment at: llvm/include/llvm/Support/KnownBits.h:309
+  static KnownBits concatBits(const KnownBits &Lo, const KnownBits &Hi) {
+    unsigned LoBits = Lo.getBitWidth();
+    unsigned HiBits = Hi.getBitWidth();
----------------
Maybe just `return { Hi.Zero.concat(Lo.Zero), Hi.One.concat(Lo.One) }`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130557/new/

https://reviews.llvm.org/D130557