[PATCH] D130155: [DeadStoreElimination] Handle null accessing

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 02:38:14 PDT 2022


nikic added a comment.

In D130155#3678941 <https://reviews.llvm.org/D130155#3678941>, @ChuanqiXu wrote:

> @nikic would you mind landing this? Since 15.x branch is going to be branched and the thread identification problem is really important to users of coroutines, I want to have a workaround for it. And there is more than one month long testing time so that we could revert it if we find anything bad.

Would it be "good enough" to mark coro.tls.wrapper as reading memory for LLVM 15, if we're adding a temporary intrinsic anyway? Or is it very important that `__attribute__((const))` functions also get "fixed"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130155/new/

https://reviews.llvm.org/D130155



More information about the llvm-commits mailing list