[PATCH] D130239: [LoongArch] Encode LoongArch specific ELF e_flags to binary by LoongArchTargetStreamer

[Lu Weining via Phabricator via llvm-commits]

SixWeining added a comment.

In D130239#3678813 <https://reviews.llvm.org/D130239#3678813>, @xen0n wrote:

> Do we have to wait before https://github.com/loongson/LoongArch-Documentation/pull/33 is merged (and perhaps the reference implementation in binutils) so we could mark LLVM-generated objects as such? The LLVM LoongArch port can never generate the old-style (stack-machine-style) relocs so I think this marker might be appropriate at all times.

Thanks. Let me look at that discussion and reply later.



================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchELFStreamer.cpp:26
+    : LoongArchTargetStreamer(S) {
+  // FIXME: select appropiate ABI.
+  setTargetABI(STI.getTargetTriple().isArch64Bit() ? LoongArchABI::ABI_LP64D
----------------
xen0n wrote:
> nit: "appropriate"
Thanks.


================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchTargetStreamer.cpp:22
+  assert(ABI != LoongArchABI::ABI_Unknown &&
+         "Improperly initialized target ABI");
+  TargetABI = ABI;
----------------
xen0n wrote:
> In `LoongArchELFStreamer.cpp` you wrote "initialised". Do we prefer British or American spelling here in LLVM?
Seems `initialized` is used more frequently in LLVM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130239/new/

https://reviews.llvm.org/D130239