[PATCH] D130239: [LoongArch] Encode LoongArch specific ELF e_flags to binary by LoongArchTargetStreamer

Tue Jul 26 01:09:46 PDT 2022

xen0n added a comment.

Do we have to wait before https://github.com/loongson/LoongArch-Documentation/pull/33 is merged (and perhaps the reference implementation in binutils) so we could mark LLVM-generated objects as such? The LLVM LoongArch port can never generate the old-style (stack-machine-style) relocs so I think this marker might be appropriate at all times.

================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchELFStreamer.cpp:26
+    : LoongArchTargetStreamer(S) {
+  // FIXME: select appropiate ABI.
+  setTargetABI(STI.getTargetTriple().isArch64Bit() ? LoongArchABI::ABI_LP64D
----------------
nit: "appropriate"

================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchTargetStreamer.cpp:22
+  assert(ABI != LoongArchABI::ABI_Unknown &&
+         "Improperly initialized target ABI");
+  TargetABI = ABI;
----------------
In `LoongArchELFStreamer.cpp` you wrote "initialised". Do we prefer British or American spelling here in LLVM?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130239/new/

https://reviews.llvm.org/D130239