[PATCH] D130506: [Support] Add llvm::compression::{isAvailable,compress,uncompress}

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/include/llvm/Support/Compression.h:32
+  DebugCompressionType Format = DebugCompressionType::None;
+  int Level = -1;
+  // This may support multi-threading for zstd in the future. Note that
----------------
MaskRay wrote:
> jhenderson wrote:
> > I don't like the magic `-1` here. I think it should either be stored in a constant, or possibly this should be an `Optional`.
> I have thought about Optional. I pick -1 to be more similar with `*::compress`'s `Level` and avoid an `Optional` include. Happy to switch though.
I'm not too fussed either way - I'd be happy with -1, if it were a named constant, e.g. `DefaultLevel` or something like that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130506/new/

https://reviews.llvm.org/D130506