[PATCH] D130506: [Support] Add llvm::compression::{isAvailable,compress,uncompress}
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 26 00:30:21 PDT 2022
jhenderson added inline comments.
================
Comment at: llvm/include/llvm/Support/Compression.h:30
namespace compression {
+struct Param {
+ DebugCompressionType Format = DebugCompressionType::None;
----------------
Since there's more than one member, it should be plural.
================
Comment at: llvm/include/llvm/Support/Compression.h:32
+ DebugCompressionType Format = DebugCompressionType::None;
+ int Level = -1;
+ // This may support multi-threading for zstd in the future. Note that
----------------
I don't like the magic `-1` here. I think it should either be stored in a constant, or possibly this should be an `Optional`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130506/new/
https://reviews.llvm.org/D130506
More information about the llvm-commits
mailing list