[PATCH] D116702: [GlobalISel] Combine select + fcmp to fminnum/fmaxnum/fminimum/fmaximum

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 23:18:05 PDT 2022


aemerson accepted this revision.
aemerson added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:5792
+  // TODO: Handle integer cases.
+  assert(MI.getOpcode() == TargetOpcode::G_SELECT);
+  // Condition may be fed by a truncated compare.
----------------
You can just cast to `GSelect` and use the convenience methods.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116702/new/

https://reviews.llvm.org/D116702



More information about the llvm-commits mailing list