[PATCH] D130142: [Coroutines] Introduce @llvm.coro.tls.wrapper to block optimizations

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added a comment.

In D130142#3677277 <https://reviews.llvm.org/D130142#3677277>, @ychen wrote:

> In D130142#3675062 <https://reviews.llvm.org/D130142#3675062>, @ChuanqiXu wrote:
>
>> Given the bug is important and the patch is relatively small and innocent, I want to land this one before 15.x branch is created if no objection comes in.
>
> Sounds good to me. One last question is: why not just use `llvm.threadlocal.address`? The plan is to replace `llvm.coro.tls.wrapper` with `llvm.threadlocal.address` right?  I'd prefer not to add an LLVM intrinsic just for one specific release.

Yeah, the plan is going to replace  `llvm.coro.tls.wrapper` with `llvm.threadlocal.address`. The reason why I introduced a new intrinsics is the semantic differences.  `llvm.threadlocal.address` is a fundamental one and `llvm.coro.tls.wrapper` is specific to coroutines. I think it might not be too bad. Since we've commented that `llvm.coro.tls.wrapper` is used internally. I feel like it might not be possible that someone else would use it accidently.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130142/new/

https://reviews.llvm.org/D130142