[PATCH] D130315: [DWARF][BOLT] Implement new mechanism for DWARFRewriter

Alexander Yermolovich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 18:19:24 PDT 2022


ayermolo added inline comments.


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:966
+                for (uint8_t byte : Tmp) {
+                  DIEBldr.addValue(NewAttr, static_cast<dwarf::Attribute>(0),
+                                   dwarf::DW_FORM_data1, DIEInteger(byte));
----------------
Not sure this logic is correct.

> The DW_OP_addrx operation has a single operand that encodes an unsigned
> 15 LEB128




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130315/new/

https://reviews.llvm.org/D130315



More information about the llvm-commits mailing list