[PATCH] D130036: [BOLT][NFC] Remove opts::AllowStripped

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 17:06:33 PDT 2022


maksfb added a comment.

I don't think `--allow-stripped` option is used anymore and it's okay to remove it. But the option changes the behavior for handling the error case and hence the change is not NFC. Could you retitle to "[BOLT] Remove --allow-stripped option"?



================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:2805
               "names. It appears that the input binary was stripped while a "
-              "profiled binary was not. If you know what you are doing and "
-              "wish to proceed, use -allow-stripped option.\n";
+              "profiled binary was not.\n";
     exit(1);
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130036/new/

https://reviews.llvm.org/D130036



More information about the llvm-commits mailing list