[PATCH] D129974: [BOLT] Support split jump table for stripped binaries

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb requested changes to this revision.
maksfb added a comment.
This revision now requires changes to proceed.

Change the summary to a narrative format.



================
Comment at: bolt/include/bolt/Core/BinaryContext.h:483
 
+  bool validJumpTableEntry(uint64_t EntryAddress, BinaryFunction *BF,
+                           BinaryFunction *&TargetBF,
----------------



================
Comment at: bolt/include/bolt/Core/BinaryContext.h:483
 
+  bool validJumpTableEntry(uint64_t EntryAddress, BinaryFunction *BF,
+                           BinaryFunction *&TargetBF,
----------------
maksfb wrote:
> 
If you don't expect a pointer parameter to be a `nullptr`, make it a reference. If you don't expect to change it, make it a const reference.

Add a description of the function and its parameters.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129974/new/

https://reviews.llvm.org/D129974