[PATCH] D130517: [GlobalISel] Add sdiv exact (X, constant) -> mul combine.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 15:18:09 PDT 2022


aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:4956-4959
+  // Don't do this for minsize because the instruction sequence is usually
+  // larger.
+  if (MF.getFunction().hasMinSize())
+    return false;
----------------
arsenm wrote:
> This greatly depends on the target handling of division and probably should be attached to the tablegen addition
Not sure what you mean by "tablegen addition"?


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:5016
+  // Collect all magic values from the build vector.
+  bool Matched = matchUnaryPredicate(MRI, RHS, BuildSDIVPattern);
+  (void)Matched;
----------------
tschuett wrote:
> Is this cuter as an if-statement to get rid of the `(void)`?
I don't think so, `(void)` is the common idiom for silencing unused variable warnings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130517/new/

https://reviews.llvm.org/D130517



More information about the llvm-commits mailing list