[PATCH] D130426: [CodeGen] Fixed ambiguous symbol ExtAddrMode in case of NDEBUG and LLVM_ENABLE_DUMP

[Dmitry Vassiliev via Phabricator via llvm-commits]

slydiman added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:2618
 
+} // end anonymous namespace
+
----------------
aaron.ballman wrote:
> +1 to not extending the anonymous namespace like this but instead using a qualified identifier as necessary.
You do realize that one cannot provide qualified name for unnamed namespace, right? But please feel free to explain if I’m missing something in your comment.
I don’t see how this change possibly violates the developers policy, since this is exactly what is done here - a class declared in an unnamed namespace along with all its memebrs to fix the defect of possible referencing symbols from outside of this CU.
As another approach, we could make that a named namespace, and use qualified names instead. This would also change the symbol visibility/linkage, which I personally do not like.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130426/new/

https://reviews.llvm.org/D130426