[PATCH] D129941: [JITLink][COFF] Implement IMAGE_COMDAT_SELECT_LARGEST partially.

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 14:51:26 PDT 2022


lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

LGTM, at least as an initial step to bring up COFF support.

So the MSVC runtime requires this? Do you know what kind of symbols the runtime uses IMAGE_COMDAT_SELECT_LARGEST for? C common symbols?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129941/new/

https://reviews.llvm.org/D129941



More information about the llvm-commits mailing list