[PATCH] D129937: [JITLink][COFF] Handle duplicate external symbols.

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

> For collection side, maybe we should change jitlink graph to store external symbols with DenseMap instead? We must iterate over the entire external_symobls() in order to check duplicate right now. (which sounded expensive for me) I always thought we should change it to densemap but didn't proceed on as it has been invalid for object file to list symbol twice.

I totally missed that you had already identified this issue @sunho. Sorry! :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129937/new/

https://reviews.llvm.org/D129937