[PATCH] D130291: [DirectX backend] [NFC]Add DXILOpBuilder to generate DXIL operation
Justin Bogner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 25 14:34:26 PDT 2022
bogner accepted this revision.
bogner added a comment.
This revision is now accepted and ready to land.
In D130291#3673098 <https://reviews.llvm.org/D130291#3673098>, @python3kgae wrote:
> Add DXILOperationCommon.h to share ParameterKind.
I'd probably put `parameterTypeNameToKind` and `getTypeFromParameterKind` in DXILOperationCommon.h as well - it makes sense for them to be next to each other since they're symmetric. Otherwise LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130291/new/
https://reviews.llvm.org/D130291
More information about the llvm-commits
mailing list