[PATCH] D130140: [ADT] Remove Optional::getValueOr (NFC)

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 12:41:59 PDT 2022


kazu added a comment.

In D130140#3677054 <https://reviews.llvm.org/D130140#3677054>, @dblaikie wrote:

>> I was originally planning to deprecate this method, but I cannot put [[deprecated]] on C++ templates.
>
> Hmm, I'm not sure I understand what you mean. It looks like you could put `[[deprecated]]` on a member function template: https://godbolt.org/z/jG1KxMT1f

Oops.  I was putting `[[deprecated]]` before `template`.  It works now with `[[deprecated]]` immediately before the return type.  Let me revise the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130140/new/

https://reviews.llvm.org/D130140



More information about the llvm-commits mailing list