[PATCH] D130431: [BOLT] Fix split jump table issues

[Amir Ayupov via Phabricator via llvm-commits]

Amir added a comment.

Good findings, and the code looks good generally.
The summary lists three separate issues, can you please split up this diff so that each is addressed separately?



================
Comment at: bolt/lib/Core/BinaryContext.cpp:666
 void BinaryContext::populateJumpTables() {
+  SmallVector<JumpTable*,1> JTableRemoveList;
   LLVM_DEBUG(dbgs() << "DataPCRelocations: " << DataPCRelocations.size()
----------------
Please add a context for this vector (e.g. "collect jump tables that failed analyzeJumpTable checks") and run clang-format on this commit.



================
Comment at: bolt/lib/Core/BinaryContext.cpp:738
 
+  // Ignore invalid jump tables
+  for (JumpTable *JT : JTableRemoveList) {
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130431/new/

https://reviews.llvm.org/D130431