[PATCH] D107280: [RISCV] Lower extern_weak symbols using the GOT for the medany model

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.
Herald added subscribers: sunshaoce, pcwang-thead, eopXD, VincentWu, luke957, StephenFan, arichardson.
Herald added a project: All.

It looks like this has been approved for roughly a year and yet hasn't landed.  Could we get this rebased and landed?

I'm aware this is somewhat still an area of controversy in the psABI, but the GOT based lowering here is conservatively correct regardless of outcome there.  If we do settle on the GOT required answer - which looks likely, having this in as early as possible should help minimize migration pain.  If we decide on requiring the relaxation, this change does no harm and could be reverted later if desired.  The only reason I can see to hold this if we think there's a potential performance concern, but if so, we really need to know that for the psABI discussion and exposing it by landing this and seeing what falls out seems like still a net win.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107280/new/

https://reviews.llvm.org/D107280