[PATCH] D130436: [BOLT] Process each block only once in fixCFGForPIC

[Fabian Parzefall via Phabricator via llvm-commits]

FPar added a comment.

In D130436#3674716 <https://reviews.llvm.org/D130436#3674716>, @maksfb wrote:

> Thanks for improving the efficiency of `fixCFGForPIC()`. The change looks fine to me. Do you think the implementation will be simpler if we make `Blocks` a queue and add newly added blocks to the end? This way we can get rid of the inner loop and dealing with `CurrentBB`/`NextBB`.

That makes totally sense. It somehow slipped my mind.

As far as I can tell, there is also no need for setting annotation in this function anymore. Is that correct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130436/new/

https://reviews.llvm.org/D130436