[PATCH] D130208: [lld-macho] Fix assertion when two symbols at same addr have unwind info

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Sorry for the slow turnaround – was at a conference last week, and don't build the iOS code all that often.

Here's a repro file: https://drive.google.com/file/d/1wMTTtgtLgrnXPZ--qpx1jUJs3spXeLmo/view?usp=sharing

The assertion used to fire for `Users/thakis/src/chrome/src/out/gnios/obj/ios/chrome/browser/ui/omnibox/popup/popup_swift/omnibox_popup_view_provider.o`. That .o file is created by compiling https://source.chromium.org/chromium/chromium/src/+/main:ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_provider.swift;l=1?q=omnibox_popup_view_provider.&sq= (I can get the exact compile command if it helps). It's a swift file, so maybe this is needed for all swift .o files? If so, this would probably slow down links of projects using swift a bit (?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130208/new/

https://reviews.llvm.org/D130208