[PATCH] D130173: [Matrix] Add assert to extractVector with undef values

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

> [Matrix] Add assert to extractVector with undef values

might be slightly clearer to say something like `[Matrix] Add assert to catch extracted vectors with poison elements`



================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:343
+                 NumElts &&
+             "Extracted vector will contain undef values");
       return Builder.CreateShuffleVector(
----------------
nit: Technically it would contain poison values now right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130173/new/

https://reviews.llvm.org/D130173