[PATCH] D130172: [Matrix] Refactor tiled loops in a struct. NFC

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 08:25:27 PDT 2022


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/include/llvm/Transforms/Utils/MatrixUtils.h:28
 /// form:
-///   for CurrentColumn = 0..NumColumns
-///     for CurrentRow = 0..NumRows
-///       for CurrentInner = 0..NumInner
+///   for Column.Index = 0..NumColumns
+///     for RowLoop.Index = 0..NumRows
----------------
nit: should this be `ColumnLoop.Index`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130172/new/

https://reviews.llvm.org/D130172



More information about the llvm-commits mailing list