[PATCH] D130232: Reassoc FMF should not optimize FMA(a, 0, b) to (b)

[Sven van Haastregt via Phabricator via llvm-commits]

svenvh added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/neon-fma-FMF.ll:64
+; CHECK: fmadd
+; CHECK-NOT: fadd
+; CHECK-NOT: fsub
----------------
spatel wrote:
> Prefer to add positive CHECK lines for correctness rather than NOT lines for the absence of one particular kind of wrong.
> It would be great to update this whole file using the script at "utils/update_llc_test_checks.py" - that way, it's complete and easier to update.
> It would be great to update this whole file using the script at "utils/update_llc_test_checks.py"

I've tried that, but it seems to remove some CHECK patterns presumably because the IR is not exactly the same for the two llc RUN invocations (yet we still want the test to verify that fma fusing happened).

Either way, I've updated the CHECK lines for this function with what `update_llc_test_checks.py` generates.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130232/new/

https://reviews.llvm.org/D130232