[PATCH] D130487: [PowerPC] Fix vector_shuffle combines when inputs are scalar_to_vector of differing types.

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 07:23:20 PDT 2022


amyk created this revision.
amyk added reviewers: power-llvm-team, PowerPC, nemanjai, stefanp.
amyk added a project: PowerPC.
Herald added subscribers: shchenz, hiraditya.
Herald added a project: All.
amyk requested review of this revision.
Herald added a project: LLVM.

This patch fixes the combines for vector_shuffles when either or both of its
left and right hand side inputs are scalar_to_vector nodes.

Previously, when both left and right side inputs are scalar_to_vector nodes,
the current combine could not handle this situation, as the shuffle mask was
updated incorrectly. https://reviews.llvm.org/D127818 was a temporary solution
to this issue. Now, not only does this patch aim to resolve the previous issue the
of incorrect shuffle mask adjustments respectively, it also updates any test cases
that are affected by this change.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D130487

Files:
  llvm/lib/Target/PowerPC/PPCISelLowering.cpp
  llvm/test/CodeGen/PowerPC/p8-scalar_vector_conversions.ll
  llvm/test/CodeGen/PowerPC/v16i8_scalar_to_vector_shuffle.ll
  llvm/test/CodeGen/PowerPC/v2i64_scalar_to_vector_shuffle.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130487.447331.patch
Type: text/x-patch
Size: 76721 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220725/f79e9ea1/attachment.bin>


More information about the llvm-commits mailing list