[PATCH] D130251: [DAGCombine] Mask doesn't have to be (EltSize - 1) exactly when combining rotation

Mon Jul 25 05:57:46 PDT 2022

pcwang-thead added a comment.

In D130251#3675652 <https://reviews.llvm.org/D130251#3675652>, @RKSimon wrote:

> In D130251#3675036 <https://reviews.llvm.org/D130251#3675036>, @pcwang-thead wrote:
>
>> Any thoughts about comments? I think they may be not matched with implementation now. @RKSimon
>
> You mean the pseudo-code that refers to 'Neg & (EltSize - 1)' etc?

Yes. Is it OK to keep the same?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130251/new/

https://reviews.llvm.org/D130251