[PATCH] D130345: [AMDGPU][MC][GFX11] Correct encoding of VOP3/VOP3_DPP v_cmpx* opcodes

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 03:38:10 PDT 2022


dp marked an inline comment as done.
dp added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp:342
+    assert((Encoding & 0xFF) == 0);
+    Encoding |= 0x7E;
+  }
----------------
critson wrote:
> Could use the following instead to avoid numeric in code?
> 
> Encoding |= MRI.getEncodingValue(AMDGPU::EXEC_LO)
Thanks. I forgot that I could have used `getEncodingValue`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130345/new/

https://reviews.llvm.org/D130345



More information about the llvm-commits mailing list