[PATCH] D130360: [llvm-objdump, ARM] Fix .byte directives dumping the wrong byte.

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham updated this revision to Diff 447233.
simon_tatham added a comment.

Good point, thanks. Updated the test to contain a more distinctive value in the final byte of the data section.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130360/new/

https://reviews.llvm.org/D130360

Files:
  llvm/test/tools/llvm-objdump/ELF/AArch64/elf-aarch64-mapping-symbols.test
  llvm/tools/llvm-objdump/llvm-objdump.cpp


Index: llvm/tools/llvm-objdump/llvm-objdump.cpp
===================================================================
--- llvm/tools/llvm-objdump/llvm-objdump.cpp
+++ llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -914,7 +914,7 @@
     return 2;
   }
   dumpBytes(Bytes.slice(Index, 1), OS);
-  OS << "\t\t.byte\t" << format_hex(Bytes[0], 4);
+  OS << "\t\t.byte\t" << format_hex(Bytes[Index], 4);
   return 1;
 }
 
Index: llvm/test/tools/llvm-objdump/ELF/AArch64/elf-aarch64-mapping-symbols.test
===================================================================
--- llvm/test/tools/llvm-objdump/ELF/AArch64/elf-aarch64-mapping-symbols.test
+++ llvm/test/tools/llvm-objdump/ELF/AArch64/elf-aarch64-mapping-symbols.test
@@ -11,8 +11,9 @@
 .section .myothersection,"ax", at progbits
   adrp x1,mystr
 mystr:
-  .asciz "blah"
+  .ascii "blah"
   .size mystr, 4
+  .byte 0x9a
 
 # CHECK: Disassembly of section .mysection:
 # CHECK: <_start>:
@@ -27,4 +28,4 @@
 # CHECK:        0:       01 00 00 90     adrp    x1, 0x0
 # CHECK: <mystr>:
 # CHECK:        4:       62 6c 61 68     .word
-# CHECK:        8:       00              .byte   0x01
+# CHECK:        8:       9a              .byte   0x9a


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130360.447233.patch
Type: text/x-patch
Size: 1186 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220725/f2e4fc0e/attachment.bin>