[PATCH] D127488: [GlobalISel][DebugInfo] Remove debug info with zero line from constants inserted at entry block

Mon Jul 25 00:02:31 PDT 2022

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

In D127488#3670446 <https://reviews.llvm.org/D127488#3670446>, @arsenm wrote:

> In D127488#3656388 <https://reviews.llvm.org/D127488#3656388>, @dblaikie wrote:
>
>>> Initially it was like that. Addressing this comment https://reviews.llvm.org/D127488#3573315, I have added more sophisticated check. Should I revert it to previous version https://reviews.llvm.org/D127488?id=435872 ?
>>
>> @arsenm what're your thoughts here? I don't feel very strongly either way, but I didn't understand the added complexity.
>
> I don't have a particularly strong opinion. I don't think it's worth adding a lot of extra complexity just for the benefit of an assert

OK, sounds good then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127488/new/

https://reviews.llvm.org/D127488