[PATCH] D127281: [Greedy RegAlloc] Fix the handling of split register in last chance re-coloring.

Sun Jul 24 22:58:03 PDT 2022

skatkov added a comment.

In D127281#3671525 <https://reviews.llvm.org/D127281#3671525>, @uabelho wrote:

> Awesome!
>
> We've seen several different crashes related to splitting happening during tryLastChanceRecoloring for our out-of-tree target over the years, and I could close all such open downstream TRs now due to this patch.
> Thanks @skatkov !

Nice to hear!

================
Comment at: llvm/test/CodeGen/AArch64/regalloc-last-chance-recolor-with-split.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mattr="+reserve-x28" --run-pass=greedy -verify-machineinstrs %s -o - | FileCheck %s

----------------
arsenm wrote:
> Probably should also run virtregrewriter
It helped.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127281/new/

https://reviews.llvm.org/D127281