[PATCH] D130454: [JITLink][COFF] Handle COMDAT symbol with offset.

Sunho Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 24 19:19:27 PDT 2022


sunho created this revision.
sunho added reviewers: lhames, sgraenitz.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
sunho requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Handles COMDAT symbol with an offset and refactor the code to only generated symbol if the second symbol was encountered. This happens very infrequently but happens in recursive_mutex implementation of MSVC STL library.


https://reviews.llvm.org/D130454

Files:
  llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp
  llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.h
  llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_any.test
  llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_exact_match.test
  llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_intervene.test
  llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_largest.test
  llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_noduplicate.test
  llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_offset.test
  llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_same_size.test
  llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_weak.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130454.447178.patch
Type: text/x-patch
Size: 13011 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220725/cf7bc607/attachment.bin>


More information about the llvm-commits mailing list